rootfs: minor systemd file deletion cleanup #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danmihai1
commented
Jan 24, 2025
danmihai1
commented
- Move the deletion of systemd units and files from image_builder.sh into rootfs.sh.
- This allows other image file formats to benefit from the deletion of unnecessary systemd units and files, not just the rootfs-image format created by image_builder.sh.
- Also, image_builder.sh was deleting these files after it calculated the size of the rootfs files, thus missing out on the opportunity to possibly create a smaller image file.
- Delete symbolic links to files being deleted.
Move the deletion of unnecessary systemd units and files from image_builder.sh into rootfs.sh. The files being deleted can be applicable to other image file formats too, not just to the rootfs-image format created by image_builder.sh. Also, image_builder.sh was deleting these files *after* it calculated the size of the rootfs files, thus missing out on the opportunity to possibly create a smaller image file. Signed-off-by: Dan Mihai <[email protected]>
Show the list of files being deleted. Signed-off-by: Dan Mihai <[email protected]>
Delete symbolic links to files being deleted. Signed-off-by: Dan Mihai <[email protected]>
ms-mahuber
approved these changes
Jan 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.