Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tardev: enable feature(impl_trait_in_assoc_type) to fix build with rust 1.72.0 #62

Closed

Conversation

mfrw
Copy link
Member

@mfrw mfrw commented Sep 21, 2023

Rust 1.72.0 build fails if we do not explicity enable feature
feature(impl_trait_in_assoc_type)

Signed-off-by: Muhammad Falak R Wani [email protected]

@danmihai1 danmihai1 requested a review from wedsonaf September 22, 2023 16:04
@danmihai1
Copy link

We can live with an occasional exception, but in general I think it's better to sign-off using our MSFT email address (not gmail).

@mfrw mfrw marked this pull request as ready for review September 22, 2023 16:12
@mfrw mfrw requested review from a team as code owners September 22, 2023 16:12
@mfrw mfrw force-pushed the mfrw/tardev-fix-1.72.0 branch from 8bbf6a9 to 16f274e Compare September 22, 2023 16:29
@mfrw mfrw changed the base branch from wedsonaf/tardev to cc-msft-prototypes September 22, 2023 16:29
@dallasd1
Copy link

We should wait until rust 1.72.0 is available to merge this since this is a breaking change without it. This patch is also needed to prevent a build break, is it something that can be added to this PR? https://github.com/microsoft/CBL-Mariner/blob/e248c3325f691c31adcdbe3cdabcb32e4ef9cea8/SPECS/kata-containers-cc/drop-mut-for-variables-that-are-not-mutated.patch

@mfrw
Copy link
Member Author

mfrw commented Oct 4, 2023

We should wait until rust 1.72.0 is available to merge this since this is a breaking change without it. This patch is also needed to prevent a build break, is it something that can be added to this PR? https://github.com/microsoft/CBL-Mariner/blob/e248c3325f691c31adcdbe3cdabcb32e4ef9cea8/SPECS/kata-containers-cc/drop-mut-for-variables-that-are-not-mutated.patch

There is a seperate PR for that:

@dallasd1
Copy link

It seems this change will be taken care of by another PR 0f5419f

@Redent0r
Copy link

Redent0r commented Dec 8, 2023

Closing since this change was included in 0f5419f

@Redent0r Redent0r closed this Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants