Skip to content

Add configprovider to openai text generation and model config #1043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

JaJamyG
Copy link

@JaJamyG JaJamyG commented Mar 25, 2025

Motivation and Context (Why the change? What's the scenario?)

I want to be able to change models from openai text generation in runtime.

High level description (Approach, Design)

The ability to change gpt models in runtime, to ask question to open ai

@JaJamyG JaJamyG requested a review from dluc as a code owner March 25, 2025 18:25
@JaJamyG
Copy link
Author

JaJamyG commented Mar 25, 2025

@JaJamyG please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

@JaJamyG
Copy link
Author

JaJamyG commented Mar 26, 2025

fixes #1042

Copy link
Collaborator

@dluc dluc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you try overriding the model?

I tested the PR, and requests are always sent to the model defined in the configuration, not the one in the context.

I suspect that the client used internally (Semantic Kernel) doesn't support passing the model ID in the request.

@dluc dluc added the waiting for author Waiting for author to reply or address comments label May 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting for author Waiting for author to reply or address comments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants