Merge pull request #4119 from microsoft/bugfix/caching-dead-lock

- fixes a deadlock when evicting cached descriptions
microsoft · Feb 5, 2024 · 1bb37db · 1bb37db
2 parents 9fb5df4 + ed59a27
commit 1bb37db
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -12,6 +12,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Changed
 
 - Fixed a deadlock on update for multiple clients targeting the same local file.
+- Fixed a deadlock when evicting cached descriptions.
 
 ## [1.11.0] - 2024-02-01
 

diff --git a/src/Kiota.Builder/Caching/DocumentCachingProvider.cs b/src/Kiota.Builder/Caching/DocumentCachingProvider.cs
@@ -62,8 +62,8 @@ private async Task<Stream> GetDocumentInternalAsync(Uri documentUri, string inte
                     Logger.LogWarning("could not delete cache file {CacheFile}, reason: {Reason}", target, ex.Message);
                 }
             }
-            return await GetDocumentInternalAsync(documentUri, intermediateFolderName, fileName, couldNotDelete, accept, token).ConfigureAwait(false);
         }
+        return await GetDocumentInternalAsync(documentUri, intermediateFolderName, fileName, couldNotDelete, accept, token).ConfigureAwait(false);
     }
     private static readonly AsyncKeyedLocker<string> _locks = new(o =>
     {