Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Express Enums better in typescript #3862

Merged
merged 16 commits into from
Dec 8, 2023
Merged

Express Enums better in typescript #3862

merged 16 commits into from
Dec 8, 2023

Conversation

koros
Copy link
Contributor

@koros koros commented Dec 5, 2023

Fixes: #2105

@koros koros requested a review from a team as a code owner December 5, 2023 16:08
baywet
baywet requested changes Dec 5, 2023
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for starting this. Left a question about the design

src/Kiota.Builder/Writers/TypeScript/CodeEnumObjectWriter.cs Outdated Show resolved Hide resolved
@koros koros changed the title Express Enums better in typescript [Draft] Express Enums better in typescript Dec 7, 2023
@koros koros changed the title [Draft] Express Enums better in typescript Express Enums better in typescript Dec 8, 2023
baywet
baywet requested changes Dec 8, 2023
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes, a few things leftover, but we're getting close.

src/Kiota.Builder/Writers/TypeScript/CodeFunctionWriter.cs Outdated Show resolved Hide resolved
src/Kiota.Builder/Writers/TypeScript/CodeFunctionWriter.cs Outdated Show resolved Hide resolved
src/Kiota.Builder/Writers/TypeScript/CodeConstantWriter.cs Outdated Show resolved Hide resolved
src/Kiota.Builder/Writers/TypeScript/CodeBlockEndWriter.cs Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

89.2% 89.2% Coverage
0.0% 0.0% Duplication

@koros koros merged commit a1f7418 into main Dec 8, 2023
@koros koros deleted the enumOptionsTs branch December 8, 2023 17:57
@lroos lroos mentioned this pull request Feb 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrueastman andrueastman andrueastman left review comments

@baywet baywet baywet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeScript better expression of enums
3 participants
@koros @andrueastman @baywet