Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unconditionally generate C# classes with nullable reference types #3945

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Unconditionally generate C# classes with nullable reference types #3945

wants to merge 1 commit into from

Conversation

0xced
Copy link
Contributor

@0xced 0xced commented Dec 21, 2023

Fixes #3944

@0xced 0xced requested a review from a team as a code owner December 21, 2023 22:50
@0xced 0xced force-pushed the unconditional-csharp-nrt branch from b750fa2 to e418974 Compare December 22, 2023 14:19
baywet
baywet requested changes Jan 8, 2024
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

holding until we get to a consensus on the issue

@0xced 0xced force-pushed the unconditional-csharp-nrt branch 2 times, most recently from 8cf210a to 4be3916 Compare January 17, 2024 10:44
@0xced 0xced force-pushed the unconditional-csharp-nrt branch from 4be3916 to 08b7bb6 Compare January 24, 2024 16:12
@0xced 0xced force-pushed the unconditional-csharp-nrt branch from 08b7bb6 to fe5f97c Compare March 7, 2024 19:16
@0xced 0xced mentioned this pull request Mar 7, 2024
Closed
@0xced 0xced force-pushed the unconditional-csharp-nrt branch from fe5f97c to 71c94d3 Compare March 8, 2024 19:46
@0xced 0xced force-pushed the unconditional-csharp-nrt branch 6 times, most recently from 6e4a216 to 3881847 Compare June 4, 2024 15:42
@0xced 0xced mentioned this pull request Jun 4, 2024
Closed
@0xced 0xced force-pushed the unconditional-csharp-nrt branch from 3881847 to 761d7e6 Compare June 6, 2024 15:08
@0xced 0xced force-pushed the unconditional-csharp-nrt branch from 761d7e6 to 7676d1a Compare June 11, 2024 13:18
@petriashev
Copy link

Waiting for this in kiota.
Too much noise

@dersia
Copy link

dersia commented Feb 10, 2025

what is this still waiting for?

@dersia dersia mentioned this pull request Feb 12, 2025
Open
@Odonno
Copy link

Odonno commented Mar 12, 2025

I am not sure what consensus is needed. Not wanted to look particularly disrespectful but having a strongly typed generated client should be common sense. Can we accelerate on this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baywet baywet baywet requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
Kiota
Status: New📃
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Kiota should unconditionally generate C# classes with nullable reference types
5 participants
@0xced @petriashev @dersia @Odonno @baywet