Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/exception doc comments #4121

Merged
merged 21 commits into from
Feb 7, 2024
Merged

feature/exception doc comments #4121

merged 21 commits into from
Feb 7, 2024

Conversation

baywet
Copy link
Member

@baywet baywet commented Feb 2, 2024

fixes #3811

@baywet baywet self-assigned this Feb 2, 2024
Base automatically changed from bugfix/caching-dead-lock to main February 5, 2024 06:32
@baywet baywet force-pushed the feature/exception-doc-comments branch from be3cd65 to f116f16 Compare February 5, 2024 15:23
@baywet baywet marked this pull request as ready for review February 5, 2024 15:23
@baywet baywet requested a review from a team as a code owner February 5, 2024 15:23
@baywet baywet enabled auto-merge February 5, 2024 15:23
andrueastman
andrueastman previously approved these changes Feb 7, 2024
baywet added 18 commits February 7, 2024 08:34
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
- adds link to types for javadoc

Signed-off-by: Vincent Biret <[email protected]>
- does not emit comment if no description is available in go

Signed-off-by: Vincent Biret <[email protected]>
- adds throws doc comment in go

Signed-off-by: Vincent Biret <[email protected]>
- fixes jsdoc implementation of return type in typescript

Signed-off-by: Vincent Biret <[email protected]>
Copy link

sonarqubecloud bot commented Feb 7, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

8 New issues
0 Security Hotspots
91.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

auto-merge was automatically disabled February 7, 2024 13:40

Pull Request is not mergeable

auto-merge was automatically disabled February 7, 2024 13:40

Pull Request is not mergeable

@baywet baywet merged commit bc2c0f5 into main Feb 7, 2024
184 of 186 checks passed
@baywet baywet deleted the feature/exception-doc-comments branch February 7, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add thrown exceptions to doc comments
2 participants