-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TypeScript writer enum default #4217
TypeScript writer enum default #4217
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution!
Can you please:
- add a unit test in code enum writer (typescript)
- add an entry in the changelog (unreleased, changed)
@lroos please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
@microsoft-github-policy-service agree |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the tests, can you also add an entry to the changelog please?
Sure; I realised I must apply the same change & test to the serializer side, but will address tomorrow. |
Ok I'm happy with changes; it's the same code path for serialize/deserialize so the test covers it. Dev build gives me the expected output. |
Pull Request is not mergeable
fixes #4216 enum default value literal