Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds plugin node in the manifest.json file if it already exists and create the manifest.json when it doesn't #4914

Merged
merged 12 commits into from
Jul 2, 2024
Merged

Adds plugin node in the manifest.json file if it already exists and create the manifest.json when it doesn't #4914

merged 12 commits into from
Jul 2, 2024

Conversation

andrueastman
Copy link
Member

@andrueastman andrueastman commented Jul 1, 2024 •
edited
Loading

Fixes #4476

If a manifest.json file exists in the folder, the plugin node is added to the file. Otherwise, a default manifest.json is added to the folder.

At the moment, this will be done when the plugin type selected is of apiplugin type.

@andrueastman andrueastman force-pushed the andrueastman/generateManifest branch 2 times, most recently from e93e899 to 057adfa Compare July 1, 2024 09:46
@andrueastman andrueastman force-pushed the andrueastman/generateManifest branch from 057adfa to 9180f60 Compare July 1, 2024 09:51
@andrueastman andrueastman marked this pull request as ready for review July 2, 2024 11:03
@andrueastman andrueastman requested a review from a team as a code owner July 2, 2024 11:03
@andrueastman andrueastman enabled auto-merge July 2, 2024 11:03
auto-merge was automatically disabled July 2, 2024 11:08

Pull Request is not mergeable

@andrueastman andrueastman enabled auto-merge July 2, 2024 13:59
@andrueastman andrueastman requested a review from baywet July 2, 2024 13:59
auto-merge was automatically disabled July 2, 2024 14:04

Pull Request is not mergeable

@andrueastman andrueastman enabled auto-merge July 2, 2024 14:07
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jul 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
87.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

auto-merge was automatically disabled July 2, 2024 14:12

Pull Request is not mergeable

baywet
baywet approved these changes Jul 2, 2024
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making the changes

@baywet baywet merged commit 59c637f into main Jul 2, 2024
205 checks passed
@baywet baywet deleted the andrueastman/generateManifest branch July 2, 2024 14:18
@andrueastman andrueastman mentioned this pull request Aug 16, 2024
Closed
andrueastman pushed a commit that referenced this pull request Aug 19, 2024
Revert "Merge pull request #4914 from microsoft/andrueastman/generate…
a8dbd29 
…Manifest"

This reverts commit 59c637f, reversing
changes made to 46ff436.
andrueastman added a commit that referenced this pull request Aug 19, 2024
@andrueastman
Merge pull request #5185 from microsoft/andrueastman/removeManifest
07818e5 
reverts changes in #4914 and #4993
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baywet baywet baywet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Kiota
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add plugin node in the manifest.json file if it already exists and create the manifest.json when it doesn't
2 participants
@andrueastman @baywet