Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize local DescriptionLocation to use / as directory separator #4932

Merged
merged 2 commits into from
Jul 4, 2024
Merged

Normalize local DescriptionLocation to use / as directory separator #4932

merged 2 commits into from
Jul 4, 2024

Conversation

ajtribick
Copy link
Contributor

This seems to be the most straightforward way of solving the issue where Windows paths fail on Linux machines, unless there are some systems which don't use the forward slash as a path separator?

Resolves #4228

@ajtribick ajtribick requested a review from a team as a code owner July 3, 2024 16:32
@ajtribick
Copy link
Contributor Author

@microsoft-github-policy-service agree

Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for starting the work on this one.
A couple of requests:

  • Can you add an entry to the changelog
  • Can you make similar changes to the workspace management? (we're in the process of migrating to a new centralized way of managing client configurations)

@ajtribick
Copy link
Contributor Author

I think this should do it. Not sure about the placement/visibility of the extension method, let me know if you have any preferences there.

Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes!

@baywet baywet merged commit 285db9f into microsoft:main Jul 4, 2024
206 checks passed
@ajtribick ajtribick deleted the path-normalization branch July 4, 2024 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kiota-lock.json changes depending on OS
3 participants