Write test log for deployment failures #3596
Conversation
adityagesh
force-pushed
the
aditya/log_deployment_failures
branch
2 times, most recently
from
a4635e1 to
a5dada8
Compare
adityagesh
force-pushed
the
aditya/log_deployment_failures
branch
from
a5dada8 to
c2accaf
Compare
adityagesh
force-pushed
the
aditya/log_deployment_failures
branch
from
c2accaf to
e69a729
Compare
adityagesh
force-pushed
the
aditya/log_deployment_failures
branch
from
e69a729 to
f4f962f
Compare
| @@ -616,12 +620,15 @@ def _attach_failed_environment_to_result( | |||
| # so deployment failure can be tracked. | |||
| environment.platform = self.platform | |||
| result.environment = environment | |||
|
|
|||
| result.subscribe_log(self._log) | |||
There was a problem hiding this comment.
Does it need to subscribe runner here? The below line result.handle_exception should have enough log. The runner is called in multi threads, and may bring logs from other cases.
There was a problem hiding this comment.
That seems to be sufficient for failed deployment.
In case of successful deployment, the deployment logs wouldn't show up in test log. That should be fine, right?
There was a problem hiding this comment.
subscribe here is too late, it won't capture the log generated when deploying. In another word, it includes nothing except the exception is logged out again.
There was a problem hiding this comment.
Are you recommending to subscribe and unsubscribe in _deploy_environment_task itself rather than _attach_failed_environment_to_result ?
There was a problem hiding this comment.
Yes, subscribe in deploy and prepare, not in the attach failed.
There was a problem hiding this comment.
I am trying to find which test result to use in _prepare_environment
There was a problem hiding this comment.
You can manually create an exception in prepare, so it can be tested easier.
adityagesh
force-pushed
the
aditya/log_deployment_failures
branch
2 times, most recently
from
a05d963 to
221f2f0
Compare
At present, test logs are not generated for deployment failures. This change creates case log for deployment failure with the failure reason.
adityagesh
force-pushed
the
aditya/log_deployment_failures
branch
from
221f2f0 to
dafbafc
Compare
At present, test logs are not generated for deployment failures. This change creates case log for deployment failure with the failure reason.