Security Profile Information #3603
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test case results should be able to differentiate between standard, secure boot, and CVM; as well as between disk encryption and no disk encryption.
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
squirrelsc
reviewed
Jan 17, 2025
| @@ -716,6 +720,21 @@ def _get_node_information(self, node: Node) -> Dict[str, str]: | |||
| node.log.debug("detecting vm generation...") | |||
| information[KEY_VM_GENERATION] = node.tools[VmGeneration].get_generation() | |||
| node.log.debug(f"vm generation: {information[KEY_VM_GENERATION]}") | |||
|
|
|||
| if node.capability and node.capability.features: | |||
| for feat in node.capability.features: | |||
There was a problem hiding this comment.
Why does it check the capability of node, not check by node.features.is_supported? The capability is what's supported by the node, but it's not the runtime value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test case results need a way to differentiate between standard, secure boot, and CVM; as well as between disk encryption and no disk encryption.