[dpdk] add symmetric_mp test #3629
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcgov
commented
Feb 5, 2025
mcgov
commented
Feb 5, 2025
mcgov
force-pushed
the
mcgov/symmetric-pr
branch
2 times, most recently
from
1181aa2 to
cc13252
Compare
squirrelsc
reviewed
Sep 15, 2025
squirrelsc
reviewed
Sep 15, 2025
mcgov
force-pushed
the
mcgov/symmetric-pr
branch
2 times, most recently
from
970e586 to
be7acdf
Compare
|
@LiliDeng LGTM |
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for the DPDK symmetric_mp multiprocessing test example, which provides better scalability than the existing client_server_mp test for handling multiple ports and processes.
Key changes include:
- Refactoring NIC initialization to accept arbitrary numbers of NICs
- Adding dpdk-devname utility to determine correct DPDK port IDs for netvsc PMD
- Implementing the symmetric_mp test runner with SRIOV rescind testing capabilities
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| dpdkutil.py | Refactored NIC handling functions and added symmetric_mp test runner |
| dpdktestpmd.py | Updated example app path resolution and added devname app support |
| dpdksuite.py | Added new test case for symmetric_mp verification |
| devname/ | Added new utility application for DPDK port ID discovery |
| lisa/nic.py | Enhanced NIC string representation with dev_uuid |
Comment on lines
1508
to
1547
| # result_regex.search(secondary_result.stdout), | ||
| # result_regex.search(primary_result.stdout), |
There was a problem hiding this comment.
Remove commented out code lines 1508-1509 as they are no longer needed and clutter the codebase.
Suggested change
| # result_regex.search(secondary_result.stdout), | |
| # result_regex.search(primary_result.stdout), |
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
Weird! I thought I had. I found another commented line as well. Thanks
LiliDeng
reviewed
Sep 18, 2025
mcgov
changed the title
working symmetric_mp for mana and mlx save state more symmetric_mp Dpdk: use more memory Dpdk: symmetric_mp test use debug messages for status Dpdk: move symmetric_mp to dpdkutil to allow rescind/non versions Dpdk: symmetric_mp polishing
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
mcgov
force-pushed
the
mcgov/symmetric-pr
branch
from
2877af6 to
1b7e71a
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
microsoft/testsuites/dpdk/symmetric_mp/symmetric-mp-patched-main.c
Dismissed
Show dismissed
Hide dismissed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a runner for the DPDK example app
multiprocessing/symmetric_mp. This is another flavor of the multiprocessing test which can scale to a larger number of ports and processes than 'multiprocessing/client_server_mp'.Adding this test required a few smaller changes (and one refactor):
With these changes, the test itself is straightforward. We build and start the application; then use enable debug logging and check for the important DPDK netvsc PMD events that show the example app is working as expected.