Add support for AN NIC without a linked synthetic device

lisa/microsoft/testsuites/core/provisioning.py

@@ -462,9 +462,9 @@ def check_sriov(self, log: Logger, node: RemoteNode) -> None:
                 pci_nic_check = True
         if pci_nic_check:
             log.info(
-                f"check_sriov: PCI nic count {len(node_nic_info.get_lower_nics())}"
+                f"check_sriov: PCI nic count {len(node_nic_info.get_pci_nics())}"
             )
-            assert_that(len(node_nic_info.get_lower_nics())).described_as(
-                f"VF count inside VM is {len(node_nic_info.get_lower_nics())},"
+            assert_that(len(node_nic_info.get_pci_nics())).described_as(
+                f"VF count inside VM is {len(node_nic_info.get_pci_nics())}, "
                 f"actual sriov nic count is {sriov_count}"
             ).is_equal_to(sriov_count)

lisa/microsoft/testsuites/kselftest/kselftest-suite.py

@@ -1,10 +1,9 @@
 from typing import Any, Dict
 
-from microsoft.testsuites.kselftest.kselftest import Kselftest
-
 from lisa import Node, TestCaseMetadata, TestSuite, TestSuiteMetadata
 from lisa.testsuite import TestResult, simple_requirement
 from lisa.util import SkippedException, UnsupportedDistroException
+from microsoft.testsuites.kselftest.kselftest import Kselftest
 
 
 @TestSuiteMetadata(

lisa/microsoft/testsuites/ltp/ltpsuite.py

@@ -4,8 +4,6 @@
 from logging import Logger
 from typing import Any, Dict
 
-from microsoft.testsuites.ltp.ltp import Ltp
-
 from lisa import (
     Node,
     TestCaseMetadata,
@@ -18,6 +16,7 @@
 from lisa.operating_system import BSD, Windows
 from lisa.testsuite import TestResult
 from lisa.tools import Lsblk, Swap
+from microsoft.testsuites.ltp.ltp import Ltp
 
 
 @TestSuiteMetadata(

lisa/microsoft/testsuites/network/common.py

@@ -205,14 +205,14 @@ def _setup_nic_monitoring(
     dest_synthetic_nic = dest_nic_info.name
 
     # Determine which NIC to monitor for packet counts
-    if source_nic_info.lower and source_nic_info.pci_device_name:
+    if source_nic_info.is_pci_module_enabled and source_nic_info.pci_device_name:
         source_pci_nic = source_nic_info.pci_device_name
         source_nic = source_pci_nic
     else:
         source_pci_nic = source_nic_info.name
         source_nic = source_synthetic_nic
 
-    if dest_nic_info.lower and dest_nic_info.pci_device_name:
+    if dest_nic_info.is_pci_module_enabled and dest_nic_info.pci_device_name:
         dest_pci_nic = dest_nic_info.pci_device_name
         dest_nic = dest_pci_nic
     else:
@@ -291,9 +291,9 @@ def sriov_vf_connection_test(
 
         # turn off lower device
         if turn_off_lower:
-            if source_nic_info.lower:
+            if source_nic_info.is_pci_module_enabled:
                 source_node.tools[Ip].down(source_pci_nic)
-            if dest_nic_info.lower:
+            if dest_nic_info.is_pci_module_enabled:
                 dest_node.tools[Ip].down(dest_pci_nic)
 
         # Perform file transfer to test connectivity
@@ -309,9 +309,9 @@ def sriov_vf_connection_test(
 
         # turn on lower device, if turned off before
         if turn_off_lower:
-            if source_nic_info.lower:
+            if source_nic_info.is_pci_module_enabled:
                 source_node.tools[Ip].up(source_pci_nic)
-            if dest_nic_info.lower:
+            if dest_nic_info.is_pci_module_enabled:
                 dest_node.tools[Ip].up(dest_pci_nic)
 
     # After testing all NICs, ensure at least one valid pair was tested

lisa/microsoft/testsuites/network/networksettings.py

@@ -100,6 +100,9 @@ class NetworkSettings(TestSuite):
         ),
     )
     def verify_ringbuffer_settings_change(self, node: Node) -> None:
+        # Skip test if no synthetic NICs are available
+        if not node.nics.get_synthetic_devices():
+            raise SkippedException("No synthetic NICs available for testing")
         ethtool = node.tools[Ethtool]
         try:
             devices_settings = ethtool.get_all_device_ring_buffer_settings()
@@ -188,6 +191,10 @@ def verify_ringbuffer_settings_change(self, node: Node) -> None:
         requirement=simple_requirement(unsupported_os=[BSD, Windows]),
     )
     def verify_device_channels_change(self, node: Node, log: Logger) -> None:
+        # Skip test if no synthetic NICs are available
+        if not node.nics.get_synthetic_devices():
+            raise SkippedException("No synthetic NICs available for testing")
+
         kernel_ver = node.tools[Uname].get_linux_information().kernel_version
         if (
             isinstance(node.os, Ubuntu)
@@ -258,6 +265,10 @@ def verify_device_channels_change(self, node: Node, log: Logger) -> None:
         priority=1,
     )
     def verify_device_enabled_features(self, node: Node) -> None:
+        # Skip test if no synthetic NICs are available
+        if not node.nics.get_synthetic_devices():
+            raise SkippedException("No synthetic NICs available for testing")
+
         required_features = [
             "rx-checksumming",
             "tx-checksumming",
@@ -298,6 +309,10 @@ def verify_device_enabled_features(self, node: Node) -> None:
         requirement=simple_requirement(unsupported_os=[BSD, Windows]),
     )
     def verify_device_gro_lro_settings_change(self, node: Node, log: Logger) -> None:
+        # Skip test if no synthetic NICs are available
+        if not node.nics.get_synthetic_devices():
+            raise SkippedException("No synthetic NICs available for testing")
+
         ethtool = node.tools[Ethtool]
 
         skip_test = True
@@ -370,6 +385,10 @@ def verify_device_gro_lro_settings_change(self, node: Node, log: Logger) -> None
         requirement=simple_requirement(unsupported_os=[BSD, Windows]),
     )
     def verify_device_rss_hash_key_change(self, node: Node, log: Logger) -> None:
+        # Skip test if no synthetic NICs are available
+        if not node.nics.get_synthetic_devices():
+            raise SkippedException("No synthetic NICs available for testing")
+
         uname = node.tools[Uname]
         linux_info = uname.get_linux_information()
 
@@ -435,6 +454,10 @@ def verify_device_rss_hash_key_change(self, node: Node, log: Logger) -> None:
         priority=2,
     )
     def verify_device_rx_hash_level_change(self, node: Node, log: Logger) -> None:
+        # Skip test if no synthetic NICs are available
+        if not node.nics.get_synthetic_devices():
+            raise SkippedException("No synthetic NICs available for testing")
+
         ethtool = node.tools[Ethtool]
 
         # Run the test for both TCP and UDP
@@ -494,6 +517,10 @@ def verify_device_rx_hash_level_change(self, node: Node, log: Logger) -> None:
         ),
     )
     def verify_device_msg_level_change(self, node: Node, log: Logger) -> None:
+        # Skip test if no synthetic NICs are available
+        if not node.nics.get_synthetic_devices():
+            raise SkippedException("No synthetic NICs available for testing")
+
         # Check if feature is supported by the kernel
         self._check_msg_level_change_supported(node)
 
@@ -605,6 +632,11 @@ def verify_device_msg_level_change(self, node: Node, log: Logger) -> None:
     def verify_device_statistics(self, environment: Environment, log: Logger) -> None:
         server_node = cast(RemoteNode, environment.nodes[0])
         client_node = cast(RemoteNode, environment.nodes[1])
+
+        # Skip test if no synthetic NICs are available
+        if not client_node.nics.get_synthetic_devices():
+            raise SkippedException("No synthetic NICs available for testing")
+
         ethtool = client_node.tools[Ethtool]
 
         self._verify_stats_exists(server_node, client_node)
@@ -614,10 +646,10 @@ def verify_device_statistics(self, environment: Environment, log: Logger) -> Non
 
         device = client_node.nics.default_nic
         nic = client_node.nics.get_nic(device)
-        if nic.lower:
+        if nic.is_pci_module_enabled:
             # If AN is enabled on this interface then use VF nic stats.
             an_enabled = True
-            device = nic.lower
+            device = nic.pci_device_name
 
         timeout = 300
         timer = create_timer()
@@ -773,9 +805,10 @@ def _verify_stats_exists(
         per_vf_queue_stats = 0
         for device_stats in devices_statistics:
             nic = client_node.nics.get_nic(device_stats.interface)
-            if nic.lower:
+            if nic.is_pci_module_enabled:
                 try:
-                    device_stats = ethtool.get_device_statistics(nic.lower, True)
+                    device_name = nic.pci_device_name
+                    device_stats = ethtool.get_device_statistics(device_name, True)
                 except UnsupportedOperationException as e:
                     raise SkippedException(e)
 

lisa/microsoft/testsuites/network/sriov.py

@@ -271,6 +271,15 @@ def verify_sriov_max_vf_connection_max_cpu(self, environment: Environment) -> No
         ),
     )
     def verify_sriov_disable_enable(self, environment: Environment) -> None:
+        # Skip test if any node has PCI-only NICs (AN without synthetic pairing)
+        for node in environment.nodes.list():
+            for nic in node.nics.nics.values():
+                if nic.is_pci_only_nic:
+                    raise SkippedException(
+                        f"SRIOV disable/enable test not applicable for "
+                        f"PCI-only NIC {nic.name} on node {node.name}."
+                    )
+
         sriov_disable_enable(environment)
 
     @TestCaseMetadata(
@@ -290,6 +299,15 @@ def verify_sriov_disable_enable(self, environment: Environment) -> None:
         ),
     )
     def verify_sriov_disable_enable_pci(self, environment: Environment) -> None:
+        # Skip test if any node has PCI-only NICs (AN without synthetic pairing)
+        for node in environment.nodes.list():
+            for nic in node.nics.nics.values():
+                if nic.is_pci_only_nic:
+                    raise SkippedException(
+                        f"SRIOV disable/enable PCI test not applicable for "
+                        f"PCI-only NIC {nic.name} on node {node.name}."
+                    )
+
         disable_enable_devices(environment)
         vm_nics = initialize_nic_info(environment)
         sriov_basic_test(environment)
@@ -314,6 +332,15 @@ def verify_sriov_disable_enable_pci(self, environment: Environment) -> None:
         ),
     )
     def verify_sriov_disable_enable_on_guest(self, environment: Environment) -> None:
+        # Skip test if any node has PCI-only NICs (AN without synthetic pairing)
+        for node in environment.nodes.list():
+            for nic in node.nics.nics.values():
+                if nic.is_pci_only_nic:
+                    raise SkippedException(
+                        f"SRIOV disable/enable on guest test not applicable "
+                        f"for PCI-only NIC {nic.name} on node {node.name}."
+                    )
+
         vm_nics = initialize_nic_info(environment)
         sriov_basic_test(environment)
         sriov_vf_connection_test(environment, vm_nics, turn_off_lower=True)

lisa/microsoft/testsuites/network/stress.py

@@ -15,6 +15,7 @@
     Environment,
     Logger,
     RemoteNode,
+    SkippedException,
     TestCaseMetadata,
     TestSuite,
     TestSuiteMetadata,
@@ -133,6 +134,15 @@ def stress_sriov_iperf(self, environment: Environment) -> None:
         ),
     )
     def stress_sriov_disable_enable(self, environment: Environment) -> None:
+        # Skip test if any node has PCI-only NICs (AN without synthetic pairing)
+        for node in environment.nodes.list():
+            for nic in node.nics.nics.values():
+                if nic.is_pci_only_nic:
+                    raise SkippedException(
+                        f"SRIOV stress disable/enable test not applicable "
+                        f"for PCI-only NIC {nic.name} on node {node.name}."
+                    )
+
         sriov_disable_enable(environment, times=50)
 
     @TestCaseMetadata(
@@ -157,6 +167,11 @@ def stress_sriov_disable_enable(self, environment: Environment) -> None:
     def stress_synthetic_provision_with_max_nics_reboot(
         self, environment: Environment
     ) -> None:
+        # Skip test if no synthetic NICs are available on any node
+        for node in environment.nodes.list():
+            if not node.nics.get_synthetic_devices():
+                raise SkippedException("No synthetic NICs available for testing")
+
         initialize_nic_info(environment, is_sriov=False)
         for _ in range(10):
             for node in environment.nodes.list():
@@ -185,6 +200,11 @@ def stress_synthetic_provision_with_max_nics_reboot(
     def stress_synthetic_with_max_nics_reboot_from_platform(
         self, environment: Environment
     ) -> None:
+        # Skip test if no synthetic NICs are available on any node
+        for node in environment.nodes.list():
+            if not node.nics.get_synthetic_devices():
+                raise SkippedException("No synthetic NICs available for testing")
+
         initialize_nic_info(environment, is_sriov=False)
         for _ in range(10):
             for node in environment.nodes.list():
@@ -214,6 +234,11 @@ def stress_synthetic_with_max_nics_reboot_from_platform(
     def stress_synthetic_with_max_nics_stop_start_from_platform(
         self, environment: Environment
     ) -> None:
+        # Skip test if no synthetic NICs are available on any node
+        for node in environment.nodes.list():
+            if not node.nics.get_synthetic_devices():
+                raise SkippedException("No synthetic NICs available for testing")
+
         initialize_nic_info(environment, is_sriov=False)
         for _ in range(10):
             for node in environment.nodes.list():

lisa/microsoft/testsuites/network/synthetic.py

@@ -2,6 +2,7 @@
 # Licensed under the MIT license.
 from lisa import (
     Environment,
+    SkippedException,
     TestCaseMetadata,
     TestSuite,
     TestSuiteMetadata,
@@ -42,6 +43,11 @@ class Synthetic(TestSuite):
     def verify_synthetic_provision_with_max_nics(
         self, environment: Environment
     ) -> None:
+        # Skip test if no synthetic NICs are available on any node
+        for node in environment.nodes.list():
+            if not node.nics.get_synthetic_devices():
+                raise SkippedException("No synthetic NICs available for testing")
+
         initialize_nic_info(environment, is_sriov=False)
 
     @TestCaseMetadata(
@@ -65,6 +71,11 @@ def verify_synthetic_provision_with_max_nics(
     def verify_synthetic_provision_with_max_nics_reboot(
         self, environment: Environment
     ) -> None:
+        # Skip test if no synthetic NICs are available on any node
+        for node in environment.nodes.list():
+            if not node.nics.get_synthetic_devices():
+                raise SkippedException("No synthetic NICs available for testing")
+
         initialize_nic_info(environment, is_sriov=False)
         for node in environment.nodes.list():
             node.reboot()
@@ -91,6 +102,11 @@ def verify_synthetic_provision_with_max_nics_reboot(
     def verify_synthetic_provision_with_max_nics_reboot_from_platform(
         self, environment: Environment
     ) -> None:
+        # Skip test if no synthetic NICs are available on any node
+        for node in environment.nodes.list():
+            if not node.nics.get_synthetic_devices():
+                raise SkippedException("No synthetic NICs available for testing")
+
         initialize_nic_info(environment, is_sriov=False)
         for node in environment.nodes.list():
             start_stop = node.features[StartStop]
@@ -118,6 +134,11 @@ def verify_synthetic_provision_with_max_nics_reboot_from_platform(
     def verify_synthetic_provision_with_max_nics_stop_start_from_platform(
         self, environment: Environment
     ) -> None:
+        # Skip test if no synthetic NICs are available on any node
+        for node in environment.nodes.list():
+            if not node.nics.get_synthetic_devices():
+                raise SkippedException("No synthetic NICs available for testing")
+
         initialize_nic_info(environment, is_sriov=False)
         for node in environment.nodes.list():
             start_stop = node.features[StartStop]
@@ -147,6 +168,11 @@ def verify_synthetic_provision_with_max_nics_stop_start_from_platform(
     def verify_synthetic_add_max_nics_one_time_after_provision(
         self, environment: Environment
     ) -> None:
+        # Skip test if no synthetic NICs are available on any node
+        for node in environment.nodes.list():
+            if not node.nics.get_synthetic_devices():
+                raise SkippedException("No synthetic NICs available for testing")
+
         remove_extra_nics(environment)
         try:
             for node in environment.nodes.list():
@@ -180,6 +206,11 @@ def verify_synthetic_add_max_nics_one_time_after_provision(
     def verify_synthetic_add_max_nics_one_by_one_after_provision(
         self, environment: Environment
     ) -> None:
+        # Skip test if no synthetic NICs are available on any node
+        for node in environment.nodes.list():
+            if not node.nics.get_synthetic_devices():
+                raise SkippedException("No synthetic NICs available for testing")
+
         remove_extra_nics(environment)
         try:
             for node in environment.nodes.list():