Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lisa/features/serial_console.py
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ class SerialConsole(Feature):
# more NUMA nodes on AMD processors.
# The call trace is annoying but does not affect correct operation of the VM.
re.compile(r"(.*RIP: 0010:topology_sane.isra.*)$", re.MULTILINE),
re.compile(r".*EFI stub:.*FIRMWARE BUG: kernel image not aligned on 64k boundary.*", re.IGNORECASE),
]

# Patterns for extracting error codes from panic messages
Expand Down
1 change: 1 addition & 0 deletions lisa/microsoft/testsuites/stress/tlb_stress.py
Original file line number Diff line number Diff line change
Expand Up @@ -715,6 +715,7 @@ def _deploy_tlb_program(self) -> None:

# Create working directory
self.node.execute(f"mkdir -p {self._work}", sudo=True)
self.node.execute(f"chmod 777 {self._work}", sudo=True)
Comment on lines 717 to +718
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the tools here


# Get the C program from the same directory
c_program_path = Path(__file__).parent / "tlb_flush_stress.c"
Expand Down
8 changes: 8 additions & 0 deletions lisa/tools/modprobe.py
Original file line number Diff line number Diff line change
Expand Up @@ -194,6 +194,14 @@ def reload(
modprobe_reloader_script: CustomScript = self.node.tools[modprobe_reloader_tool]
modprobe_reloader_script.run(parameters, sudo=True, shell=True, nohup=True)

original_user = self.node.connection_info.get('username', None)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use node.tools[Whoami].get_username()

if original_user:
self.node.execute(
f"chown {original_user}:{original_user} {loop_process_pid_file_name}",
sudo=True,
Comment on lines +199 to +201
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use tool here as well

shell=True,
)

cat = self.node.tools[Cat]
tried_times: int = 0
timer = create_timer()
Expand Down
Loading