ch: Fix comprehensive diagnostic logging issues #4153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
vyadavmsft
commented
Dec 12, 2025
vyadavmsft
commented
- Core filename pattern consistency (core.integration-* for both generate and search)
- Capture stderr in main log (2>&1 | tee -a) for reliable watchdog detection
- Write live backtrace to BOTH main log and side file with markers
- Robust binary discovery with fallback to cloud-hypervisor binary
- Capture stderr in per-test metrics logs
- Harden CH watchdog diagnostics against pid race
- Validate selected pid is alive before gcore/gdb attach
- Log attach context (cmdline/parent pid) for troubleshooting
- Retry gdb attach against parent pid when target exits
- Core filename pattern consistency (core.integration-* for both generate and search) - Capture stderr in main log (2>&1 | tee -a) for reliable watchdog detection - Write live backtrace to BOTH main log and side file with markers - Robust binary discovery with fallback to cloud-hypervisor binary - Capture stderr in per-test metrics logs - Harden CH watchdog diagnostics against pid race - Validate selected pid is alive before gcore/gdb attach - Log attach context (cmdline/parent pid) for troubleshooting - Retry gdb attach against parent pid when target exits
lubaihua33
reviewed
Dec 16, 2025
| -ex "set backtrace limit 64" \\ | ||
| -ex "thread apply all bt" \\ | ||
| -ex "info threads" > "$live_bt_file" 2>&1 || true | ||
| ps -eL -o pid,tid,ppid,stat,etime,comm,cmd | head -200 \\ |
Collaborator
There was a problem hiding this comment.
Please check the indentation.
| # Use consistent core filename pattern that matches search pattern | ||
| for dir in . .. /var/crash /cores /var/lib/systemd/coredump /tmp; do | ||
| c=$(ls -t "$dir"/core.integration-* 2>/dev/null | head -1) | ||
| c=$(ls -t "$dir"/core.integration-* "$dir"/core.* 2>/dev/null \\ |
Collaborator
There was a problem hiding this comment.
Please check the indentation.
| [ -z "$bin" ] && bin=$(ls -t **/target/*/deps/integration-* 2>/dev/null \\ | ||
| | head -1 || true) | ||
| # Fall back to cloud-hypervisor binary if integration test binary not found | ||
| [ -z "$bin" ] && bin="$(command -v cloud-hypervisor || true)" |
Collaborator
There was a problem hiding this comment.
Please check the indentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.