bugfix: fixing test_markitdown.py; updating exception messages

microsoft · Dec 27, 2024 · f07ea3e · f07ea3e
1 parent 8482477
commit f07ea3e
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 10 deletions.
diff --git a/src/markitdown/_markitdown.py b/src/markitdown/_markitdown.py
@@ -702,8 +702,8 @@ def convert(
             return None
         if engine is not None and engine not in self._engines:
             raise FileConversionException(
-                "'pdf_engine' not valid. Please choose between {}.".format(
-                    list(self._engines.keys())
+                "'engine' not valid for {} files. Please choose between {}.".format(
+                    extension, list(self._engines.keys())
                 )
             )
         else:

diff --git a/tests/test_markitdown.py b/tests/test_markitdown.py
@@ -308,7 +308,7 @@ def test_markitdown_pdf() -> None:
         os.path.join(TEST_FILES_DIR, "2308.08155v2.pdf"),
         engine="pymupdf4llm",
 
-        engine_kwargs={"show_progress": False, "pages": [i for i in range(10)],},  # additional kwargs
+        engine_kwargs={"show_progress": False, "pages": range(10),},  # additional kwargs
     )
     for test_string in PDF_TEST_STRINGS:
         assert test_string in result.text_content
@@ -321,7 +321,7 @@ def test_markitdown_pdf() -> None:
             "show_progress": False,
             "write_images": True,
             "image_path": "tests/out",
-            "pages": [i for i in range(10)],
+            "pages": range(10),
         },  # `write_images` must be True, setting `image_path` for images saving dir.
     )
     for test_string in PDF_TEST_STRINGS:
@@ -330,16 +330,16 @@ def test_markitdown_pdf() -> None:
     # By pdfminer
     result = markitdown.convert(
         os.path.join(TEST_FILES_DIR, "2308.08155v2.pdf"), engine="pdfminer",
-        enging_kwargs={"page_numbers": [i for i in range(10)],}
+        enging_kwargs={"page_numbers": range(10),}
     )
     for test_string in PDF_TEST_STRINGS:
         assert test_string in result.text_content
 
 if __name__ == "__main__":
     """Runs this file's tests from the command line."""
-    # test_markitdown_remote()
-    # test_markitdown_local()
-    # test_markitdown_exiftool()
-    # test_markitdown_deprecation()
-    # test_markitdown_llm()
+    test_markitdown_remote()
+    test_markitdown_local()
+    test_markitdown_exiftool()
+    test_markitdown_deprecation()
+    test_markitdown_llm()
     test_markitdown_pdf()