fix(docx): ignore malformed styles missing type#2190
Open
gingerninja85 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a DOCX conversion crash when
word/styles.xmlcontains a malformedw:styleentry without the requiredw:typeattribute.Mammoth indexes
style_element.attributes["w:type"], so these malformed style records currently bubble up as:This patch extends DOCX preprocessing to remove only malformed style definitions missing
w:typeorw:styleId, allowing body text conversion to continue instead of failing the whole document.Fixes #2166.
Verification
I also ran
hatch test; it reached332 passed, 4 skippedwith one local environment failure unrelated to this change becauseffprobeis not installed fortests/test_module_misc.py::test_speech_transcription.