Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docker): improve dockerfile build #220

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

feat(docker): improve dockerfile build #220

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1c01787
refactor(docker): remove unnecessary root user
syaghoubi00 Dec 26, 2024
4da26d3
fix(docker): use generic nobody nogroup default instead of uid gid
syaghoubi00 Dec 26, 2024
e5b8b1b
fix(docker): build app from source locally instead of installing package
syaghoubi00 Dec 26, 2024
cbeee42
fix(docker): use correct files in dockerignore
syaghoubi00 Dec 26, 2024
a02212d
chore(docker): dont install recommended packages with git
syaghoubi00 Dec 26, 2024
310ba02
fix(docker): run apt as non-interactive
syaghoubi00 Dec 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .dockerignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,5 @@
*
*
!src/
!tests/
!pyproject.toml
!README.md
14 changes: 9 additions & 5 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,22 +1,26 @@
FROM python:3.13-slim-bullseye

USER root
ENV DEBIAN_FRONTEND=noninteractive

ARG INSTALL_GIT=false
RUN if [ "$INSTALL_GIT" = "true" ]; then \
apt-get update && apt-get install -y git && rm -rf /var/lib/apt/lists/*; \
apt-get update && apt-get install -y --no-install-recommends \
git \
&& rm -rf /var/lib/apt/lists/*; \
fi

# Runtime dependency
RUN apt-get update && apt-get install -y --no-install-recommends \
ffmpeg \
&& rm -rf /var/lib/apt/lists/*

RUN pip install markitdown
WORKDIR /app
COPY . /app
RUN pip --no-cache-dir install .

# Default USERID and GROUPID
ARG USERID=10000
ARG GROUPID=10000
ARG USERID=nobody
ARG GROUPID=nogroup

USER $USERID:$GROUPID

Expand Down