Fix azureterraform_azapi_get to return 400 BadRequest for invalid resource type or API version

servers/Azure.Mcp.Server/changelog-entries/yunliu1-azapi-get-bad-request.yaml

@@ -0,0 +1,3 @@
+changes:
+  - section: "Bugs Fixed"
+    description: "Fixed `azureterraform_azapi_get` returning `500 InternalServerError` for invalid resource type or API version inputs. The tool now returns `400 BadRequest` with an actionable message, enabling agents to auto-correct and retry with valid inputs."

tools/Azure.Mcp.Tools.AzureTerraform/src/Commands/AzApiDocsGetCommand.cs

@@ -1,6 +1,7 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
 
+using System.IO;
 using System.Net;
 using Azure.Mcp.Tools.AzureTerraform.Models;
 using Azure.Mcp.Tools.AzureTerraform.Options;
@@ -55,6 +56,12 @@ protected override AzApiDocsOptions BindOptions(ParseResult parseResult)
         };
     }
 
+    protected override HttpStatusCode GetStatusCode(Exception ex) => ex switch
+    {
+        InvalidDataException => HttpStatusCode.BadRequest,
+        _ => base.GetStatusCode(ex)
+    };
+
     public override async Task<CommandResponse> ExecuteAsync(
         CommandContext context,
         ParseResult parseResult,

tools/Azure.Mcp.Tools.AzureTerraform/src/Services/AzApiDocsService.cs

@@ -21,7 +21,19 @@ public sealed class AzApiDocsService : IAzApiDocsService
     public AzApiDocsResult GetDocumentation(string resourceTypeName, string? apiVersion = null)
     {
         var serviceProvider = s_schemaServiceProvider.Value;
-        TypesDefinitionResult typesResult = SchemaGenerator.GetResourceTypeDefinitions(serviceProvider, resourceTypeName, apiVersion);
+        TypesDefinitionResult typesResult;
+        try
+        {
+            typesResult = SchemaGenerator.GetResourceTypeDefinitions(serviceProvider, resourceTypeName, apiVersion);
+        }
+        catch (InvalidDataException)
+        {
+            throw;
+        }
+        catch (Exception ex)
+        {
+            throw new InvalidDataException(ex.Message, ex);
+        }
         List<ComplexType> complexTypes = SchemaGenerator.GetResponse(typesResult);
 
         string resolvedApiVersion = typesResult.ApiVersion;

tools/Azure.Mcp.Tools.AzureTerraform/tests/Azure.Mcp.Tools.AzureTerraform.Tests/AzApiDocsGetCommandTests.cs

@@ -136,7 +136,7 @@ public async Task ExecuteAsync_ServiceThrows_HandlesException()
 
         var response = await ExecuteCommandAsync("--resource-type", "Microsoft.Fake/nonexistent");
 
-        Assert.NotEqual(HttpStatusCode.OK, response.Status);
+        Assert.Equal(HttpStatusCode.BadRequest, response.Status);
     }
 
     [Theory]