Open
Conversation
bl0
requested changes
Jan 27, 2021
Collaborator
bl0
left a comment
There was a problem hiding this comment.
Thanks a lot for your work. But maybe you should address the following two concerns before the PR is merged.
- You should reformat the code to make it clean.
- Maybe you should make it runnable.
aab4948 to
7a10c29
Compare
Author
|
Thank you, I refactored it and included a sample code for imagenet dataset. |
Collaborator
|
Thanks a lot for your quick reply. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I am writing from my first account. I would like to add an option for supervised metric pretraining. It is used with LinearAverage from LinearAverage.py since the output is expected to be passed to this class. It performs eq. (4) as mentioned in https://arxiv.org/pdf/1812.08781.pdf. Also, I found using the temperature parameter handy, as mentioned in https://arxiv.org/pdf/1805.01978.pdf. Thanks for your consideration.