Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NvmExpressDxe: Request Number of Queues from Controller #1260

Draft
wants to merge 2 commits into
base: dev/202405
Choose a base branch
from

Conversation

VivianNK
Copy link
Contributor

Description

Request Number of Queues from the Controller

  • Impacts functionality?
  • Impacts security?
  • Breaking change?
  • Includes tests?
  • Includes documentation?
  • Backport to release branch?

How This Was Tested

<Describe the test(s) that were run to verify the changes.>

Integration Instructions

<Describe how these changes should be integrated. Use N/A if nothing is required.>

@github-actions github-actions bot added the impact:non-functional Does not have a functional impact label Jan 24, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 0% with 164 lines in your changes missing coverage. Please review.

Project coverage is 1.19%. Comparing base (0a2c88b) to head (b273e57).
Report is 18 commits behind head on dev/202405.

Files with missing lines Patch % Lines
MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpress.c 0.00% 83 Missing ⚠️
MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressHci.c 0.00% 81 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##           dev/202405    #1260      +/-   ##
==============================================
+ Coverage        1.02%    1.19%   +0.17%     
==============================================
  Files            1377     1377              
  Lines          357007   357620     +613     
  Branches         5341     5524     +183     
==============================================
+ Hits             3665     4291     +626     
- Misses         352199   352551     +352     
+ Partials         1143      778     -365     
Flag Coverage Δ
MdeModulePkg 0.67% <0.00%> (+0.27%) ⬆️
NetworkPkg 0.55% <ø> (ø)
PolicyServicePkg 30.41% <ø> (+1.65%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Added unions to support using the Set Feature
Command for Number of Queues.

Signed-off-by: Vivian Nowka-Keane <[email protected]>
the controller.

Instead of assuming we always want to create two sets of data queues,
we request two and the controller will determine how many are allocated.

Signed-off-by: Vivian Nowka-Keane <[email protected]>
@VivianNK VivianNK force-pushed the personal/vnowkakeane/nvme_num_queues branch from cd8f50a to b273e57 Compare January 28, 2025 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact:non-functional Does not have a functional impact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants