Fix make_mlp_unpacked with lora #1209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apsonawane
previously approved these changes
Jan 30, 2025
kunal-vaishnavi
approved these changes
Jan 31, 2025
jambayk
force-pushed
the
jambayk/mlp-unpacked-lora
branch
from
ba0f867 to
df12a59
Compare
baijumeswani
pushed a commit
that referenced
this pull request
Feb 4, 2025
- The check was done on the `mlp` module instead of the `gate_up_linear` module so it always returned False. - Need to access lora_B from `gate_up_linear`. - Code referred to k_proj and v_proj
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mlpmodule instead of thegate_up_linearmodule so it always returned False.gate_up_linear.