Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin NDK version #1250

Merged
merged 5 commits into from
Feb 13, 2025
Merged

Pin NDK version #1250

merged 5 commits into from
Feb 13, 2025

Conversation

baijumeswani
Copy link
Collaborator

Android NDK version 28.x uses LLVM 19+ which is not compatible with dlib. dlib is an ort-extensions dependency that gets built when building ort-genai.

As a workaround, pinning ndk version to 27.x.

More details here: davisking/dlib#3045

snnn
snnn previously approved these changes Feb 13, 2025
Copy link
Member

@snnn snnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ORT is also using NDK 27 right now.

@snnn
Copy link
Member

snnn commented Feb 13, 2025

It seems like there is an issue in android_x64's yaml file.

@baijumeswani
Copy link
Collaborator Author

It seems like there is an issue in android_x64's yaml file.

The runner.temp is not available before the run starts. So, had to move it to later during the run

@baijumeswani baijumeswani merged commit 391bce3 into main Feb 13, 2025
14 checks passed
@baijumeswani baijumeswani deleted the baijumeswani/pin-ndk-version branch February 13, 2025 21:40
baijumeswani added a commit that referenced this pull request Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants