Add possibility to add graph optimization level to session options #1268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree |
| @@ -62,6 +62,19 @@ struct ProviderOptionsArray_Element : JSON::Element { | |||
| ProviderOptionsObject_Element object_{v_}; | |||
| }; | |||
|
|
|||
| GraphOptimizationLevel getGraphOptimizationLevel(std::string_view name) { | |||
There was a problem hiding this comment.
To keep in style with the casing used in other methods within this file:
Suggested change
| GraphOptimizationLevel getGraphOptimizationLevel(std::string_view name) { | |
| GraphOptimizationLevel GetGraphOptimizationLevel(std::string_view name) { |
|
Thanks for your contribution! A PR was recently merged that should fix the Hugging Face authentication errors. Can you merge main into your branch to resolve those CI errors? |
|
@benHeid the changes look good. Could you please address @kunal-vaishnavi's comment and the lint errors? We can merge this in then. |
| } else if (name == "ORT_ENABLE_ALL") { | ||
| return ORT_ENABLE_ALL; | ||
| } else | ||
| throw JSON::unknown_value_error{}; |
There was a problem hiding this comment.
Suggested change
| throw JSON::unknown_value_error{}; | |
| throw std::runtime_error("Unrecognized value:" + name); |
This exception isn't what you want, it's to say that the value name is unknown (it'll say "graph_optimization_level" is not recognized). The value name is recognized, but it's being set to an unrecognized value. This should be more useful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the option to set the graph optimization level when running a model.
See discussion in #1260 (reply in thread)
(Disclaimer: I am not very familiar with cpp, so any hints for improving my changes are very very welcome)