Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ACL option parsing #23586

Merged
merged 1 commit into from
Feb 17, 2025
Merged

Conversation

MichaelTylerArm
Copy link
Contributor

Description

Fixes a compiler error in the ACL option parsing for perftest.

Motivation and Context

Fixes a compiler error when building with the ACL execution provider.

Signed-off-by: Michael Tyler <[email protected]>
@MichaelTylerArm
Copy link
Contributor Author

@jywu-msft Can you trigger the workflows please?

@jywu-msft
Copy link
Member

/azp run Big Models,Linux Android Emulator QNN CI Pipeline,Win_TRT_Minimal_CUDA_Test_CI,Windows ARM64 QNN CI Pipeline,Windows CPU CI Pipeline,Windows GPU CUDA CI Pipeline,Windows GPU DML CI Pipeline,Windows GPU Doc Gen CI Pipeline,Windows GPU TensorRT CI Pipeline,Windows x64 QNN CI Pipeline

@jywu-msft
Copy link
Member

/azp run Linux CPU CI Pipeline, Linux CPU Minimal Build E2E CI Pipeline, Linux GPU CI Pipeline, Linux GPU TensorRT CI Pipeline, MacOS CI Pipeline, ONNX Runtime Web CI Pipeline, onnxruntime-binary-size-checks-ci-pipeline, Linux QNN CI Pipeline

Copy link

Azure Pipelines successfully started running 10 pipeline(s).

Copy link

Azure Pipelines successfully started running 8 pipeline(s).

@MichaelTylerArm
Copy link
Contributor Author

Those two GPU test failures look completely unrelated to this change; the changed lines shouldn't even be present in the build. Is it possible to rerun those two tests?

@jywu-msft
Copy link
Member

/azp run Linux OpenVINO CI Pipeline

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@MichaelTylerArm
Copy link
Contributor Author

Looks like the tests passed this time, can someone review please?

@jywu-msft jywu-msft merged commit 8901718 into microsoft:main Feb 17, 2025
78 checks passed
jingyanwangms added a commit that referenced this pull request Feb 18, 2025
guschmue pushed a commit that referenced this pull request Mar 6, 2025
### Description
Fixes a compiler error in the ACL option parsing for perftest.



### Motivation and Context
Fixes a compiler error when building with the ACL execution provider.

Signed-off-by: Michael Tyler <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants