[CUDA] Fix BeamSearchTest.DummyT5WithSequenceInputIds test failure in Windows #23596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
onnxruntime/contrib_ops/cuda/transformers/generation_cuda_impl.h
Outdated
Show resolved
Hide resolved
onnxruntime/contrib_ops/cuda/transformers/generation_cuda_impl.h
Outdated
Show resolved
Hide resolved
onnxruntime/contrib_ops/cuda/transformers/generation_cuda_impl.h
Outdated
Show resolved
Hide resolved
snnn
approved these changes
Feb 6, 2025
|
/azp run Linux GPU CI Pipeline |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
BeamSearchTest.DummyT5WithSequenceInputIds failed in Windows due to early stopping triggered. The cause is state.early_stopping_ is interpreted as true in cuda kernel at some point, however printf still show its value is false. The root cause is unknown.
Update the code to use early_stopping as template parameter seems walk around the issue.
Other changes:
Motivation and Context
Fix a unit test BeamSearchTest.DummyT5WithSequenceInputIds failure in Windows.