Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an installation issue related to absl #23641

Merged
merged 2 commits into from
Feb 11, 2025
Merged

Conversation

snnn
Copy link
Member

@snnn snnn commented Feb 11, 2025

It was not my first time making such errors: the extra word after the "FIND_PACKAGE_ARGS" keyword would be silently ignored by CMake. For example, when you review this change, you see "EXCLUDE_FROM_ALL" string is highlighted by Github, right? Yes, it is a keyword. But all such keywords must be before the FIND_PACKAGE_ARGS string.

The issue was introduced in PR #23426 on February 5, 2025. Intel engineers reported this issue to us on February 10, 2025. Without this fix, you may see errors like:

CMake Error at cmake_install.cmake:47 (include):
  include could not find requested file:

    /home/abc/src/onnxruntime/f58/Debug/_deps/abseil_cpp-build/cmake_install.cmake

When running "make install" command after successfully building onnxruntime without vcpkg.
The issue doesn't exist when vcpkg is enabled.

@snnn snnn merged commit d3b046e into microsoft:main Feb 11, 2025
92 of 94 checks passed
@snnn snnn deleted the snnn/fix_absl_port branch February 11, 2025 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants