Skip to content

[WebNN] Always execute decomposed *SimplifiedLayerNormalization in FP32 #24437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 22, 2025

Conversation

Honry
Copy link
Contributor

@Honry Honry commented Apr 16, 2025

Decomposed [Skip]SimplifiedLayerNormalization will lose precision in FP16, we'd like to add cast (to: fp32) ops around it in WebNN EP to ensure its precision rather than manually add cast nodes in each model file.

@Honry Honry force-pushed the cast-to-fp32-sim-layernorm branch from 3cd14fd to d14f09d Compare April 16, 2025 00:55
@Honry
Copy link
Contributor Author

Honry commented Apr 16, 2025

@fdwr, @guschmue, PTAL, thanks!

@guschmue guschmue added the ep:WebNN WebNN execution provider label Apr 16, 2025
guschmue
guschmue previously approved these changes Apr 16, 2025
Copy link
Contributor

@fdwr fdwr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

Honry added 2 commits April 21, 2025 10:38
Decomposed [Skip]SimplifiedLayerNormalization will lose precision in FP16,
we'd like to add cast (to: fp32) ops around it in WebNN EP to ensure its
precision rather than manually add cast nodes in each model file.
@Honry
Copy link
Contributor Author

Honry commented Apr 21, 2025

@fdwr, thanks for your comments, fixed in new commit, PTAL again.

Copy link
Contributor

@fdwr fdwr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@fdwr
Copy link
Contributor

fdwr commented Apr 21, 2025

/azp run ONNX Runtime Web CI Pipeline,Windows GPU CI Pipeline,Linux Android Emulator QNN CI Pipeline,Windows GPU WebGPU CI Pipeline,Windows OpenVINO CI Pipeline

@fdwr
Copy link
Contributor

fdwr commented Apr 21, 2025

/azp run Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,Windows ARM64 QNN CI Pipeline,Windows CPU CI Pipeline

@fdwr
Copy link
Contributor

fdwr commented Apr 21, 2025

/azp run Windows GPU CUDA CI Pipeline,Windows GPU DML CI Pipeline,Windows GPU Doc Gen CI Pipeline,Win_TRT_Minimal_CUDA_Test_CI

@fdwr
Copy link
Contributor

fdwr commented Apr 21, 2025

/azp run Windows GPU TensorRT CI Pipeline,onnxruntime-binary-size-checks-ci-pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule-distributed,Windows x64 QNN CI Pipeline,Big Models

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

1 similar comment
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@fdwr
Copy link
Contributor

fdwr commented Apr 22, 2025

Merging since these 5 failures are unrelated, persistent, and pervasive.

failed to authorize: failed to fetch anonymous token: unexpected status from GET request

@fdwr fdwr merged commit 1c6d07f into microsoft:main Apr 22, 2025
71 of 76 checks passed
intbf pushed a commit to intbf/onnxruntime that referenced this pull request Apr 25, 2025
…32 (microsoft#24437)

Decomposed [Skip]SimplifiedLayerNormalization will lose precision in
FP16, we'd like to add cast (to: fp32) ops around it in WebNN EP to
ensure its precision rather than manually add cast nodes in each model
file.

Signed-off-by: bfilipek <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ep:WebNN WebNN execution provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants