Skip to content

Conversation

snnn
Copy link
Member

@snnn snnn commented Sep 9, 2025

This PR updates PyTorch to version 2.8.0 in all requirements.txt files. I have also updated openai-whisper to the latest version (20250625) to fix installation issues.

This change is for addressing the CVE-2025-32434 .

@snnn
Copy link
Member Author

snnn commented Sep 10, 2025

I have updated the requirements.txt files to fix the installation issues. I also found an issue with the openai-whisper package, which seems to be a problem with the package itself. I have updated the package to the latest stable version and added a note about the issue in the code.

@snnn snnn marked this pull request as ready for review September 10, 2025 03:47
transformers==4.52.3
openai-whisper==20240927
openai-whisper==20250625
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was a bug with newer versions of openai-whisper because of the introduction of SDPA.

# NOTE: There is a bug with openai-whisper==20240930 with the introduction of SDPA.
# In the Whisper codebase, the following line
#
# is_causal = mask is not None and n_ctx > 1
#
# has been added where `mask` is a torch tensor. The right-hand side evaluates to `tensor(True/False)`
# but `is_causal` only accepts the boolean value. The fix is to apply `.item()` after the right-hand
# side has been evaluated. In other words, the line should be
#
# is_causal = (mask is not None and n_ctx > 1).item()
#
# instead.

Has this been resolved with the 20250625 release? You can test it out by running the conversion and adding --model_impl openai to your command.

@snnn snnn marked this pull request as draft September 10, 2025 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants