Fix FlashAttentionDecodeSplitVx indirect dispatch input ordering#27926
Merged
Conversation
Contributor
Author
|
The error to fix: |
Contributor
Author
qjia7
reviewed
Apr 1, 2026
03dc351 to
1a33a05
Compare
qjia7
approved these changes
Apr 1, 2026
Contributor
Author
|
@guschmue PTAL, just a gentle reminder. |
Contributor
|
/azp run Linux QNN CI Pipeline,Win_TRT_Minimal_CUDA_Test_CI,Windows ARM64 QNN CI Pipeline,Windows GPU Doc Gen CI Pipeline |
|
Azure Pipelines successfully started running 4 pipeline(s). |
Contributor
|
some unrelated error with tests running on xnnpack but only on macos. |
Move SetIndirectDispatchTensor after all AddInput calls to ensure the indirect buffer is the last program input. When head_sink was added after SetIndirectDispatchTensor, the shader variable types were swapped, causing a u32*f16 WGSL compilation error.
1a33a05 to
b068cf8
Compare
Contributor
Author
|
Rebased on main. Please help try again. Thanks! |
guschmue
approved these changes
Apr 13, 2026
Contributor
|
/azp run Linux QNN CI Pipeline,Win_TRT_Minimal_CUDA_Test_CI,Windows ARM64 QNN CI Pipeline,Windows GPU Doc Gen CI Pipeline |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Contributor
|
/azp run Windows ARM64 QNN CI Pipeline |
|
No pipelines are associated with this pull request. |
Contributor
|
/azp run Windows ARM64 QNN CI Pipeline |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move SetIndirectDispatchTensor after all AddInput calls to ensure the
indirect buffer is the last program input.