Skip to content

Fix universal package version validation comment and add SHA prefix #28248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
edgchen1 merged 1 commit into from
Apr 28, 2026
+6 −3
Merged

Fix universal package version validation comment and add SHA prefix #28248

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions tools/ci_build/github/azure-pipelines/templates/set-plugin-build-variables-step.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,10 @@ steps:
print("##vso[task.logissue type=error]Failed to get git info: {}".format(e))
sys.exit(1)
version_string = "{}-dev.{}+{}".format(original_ver, date_str, commit_sha)
universal_version = "{}-dev.{}.{}".format(original_ver, date_str, commit_sha)
# Prefix the SHA with "commit-" so the pre-release identifier always contains a
# non-digit. Otherwise, an all-numeric short SHA with a leading zero (e.g. "01234567")
# would violate SemVer 2.0.0's rule against leading zeros in numeric identifiers.
universal_version = "{}-dev.{}.commit-{}".format(original_ver, date_str, commit_sha)

else:
print("##vso[task.logissue type=error]Unknown package_version '{}'. Must be 'release', 'RC', or 'dev'.".format(package_version))
Expand All @@ -74,10 +77,10 @@ steps:
print("##vso[task.logissue type=error]Version string '{}' is not valid semver 2.0.0.".format(version_string))
sys.exit(1)

# Validate universal version (SemVer 1.0.0 - no build metadata)
# Validate universal version (SemVer 2.0.0, without build metadata)
universal_semver_pattern = r"^(0|[1-9]\d*)\.(0|[1-9]\d*)\.(0|[1-9]\d*)(?:-((?:0|[1-9]\d*|\d*[a-zA-Z-][0-9a-zA-Z-]*)(?:\.(?:0|[1-9]\d*|\d*[a-zA-Z-][0-9a-zA-Z-]*))*))?$"
if not re.match(universal_semver_pattern, universal_version):
print("##vso[task.logissue type=error]Universal version string '{}' is not valid semver 1.0.0.".format(universal_version))
print("##vso[task.logissue type=error]Universal version string '{}' is not valid semver 2.0.0 (without build metadata).".format(universal_version))
sys.exit(1)

print("##vso[task.setvariable variable=PluginPackageVersion]{}".format(version_string))
Expand Down
Loading