-
Notifications
You must be signed in to change notification settings - Fork 118
vmbus_server: Move modify_connection into restore and post_restore into start #1165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
vmbus_server: Move modify_connection into restore and post_restore into start #1165
Conversation
I considered adding a flag to |
I will remove |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments
040b9b6
to
a79eb7d
Compare
a79eb7d
to
1484a31
Compare
In order to more closely map OpenVMM's restore process onto Hyper-V, remove the need to manually call
ServerWithNotifier::post_restore
afterServer::restore
.Server::restore
toServerWithNotifier
so we can callmodify_connection
,modify_connection
request frompost_restore
intorestore
,post_restore
torevoke_unclaimed_channels
.VmbusRequest::PostRestore
and move therevoke_unclaimed_channels
call intoStart
,ModifyConnectionRequest::force
, becauseServerWithNotifier::restore_channel
is now called aftermodify_connection
, meaning there will be no open channels before the latter call.