petri: use com3 for kmsg logs #1176
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstarks
reviewed
Apr 10, 2025
| let firmware_load_path = r#"HKLM\Software\Microsoft\Windows NT\CurrentVersion\Virtualization"#; | ||
| xshell::cmd!(sh, "reg add {firmware_load_path} /v AllowFirmwareLoadFromFile /t REG_DWORD /d 1 /f").run()?; | ||
|
|
||
| // Enable COM3 and COM4 for Hyper-V VMs so we can get the OpenHCL KMSG logs over serial | ||
| xshell::cmd!(sh, "Enable-VelocityFeature -Feature 21938063").run()?; |
There was a problem hiding this comment.
No. This is an internal thing.
I thought we added a reg key or another mechanism to enable COM3, without velocity.
There was a problem hiding this comment.
Fixed to use the registry key
There was a problem hiding this comment.
Looks like that reg key did not make it to ge_release, which is what we use for our 1es test runners.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using COM3 instead of diag_client allows us to get OpenHCL logs if it crashes early in boot