fix(ci): preserve recipe failure diagnostics - #110
Conversation
Make the recipe-running step propagate its own exit status, add actionable coverage failure details, and publish completed coverage reports even after failures. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (97.6%) is below the target coverage (100.0%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #110 +/- ##
======================================
Coverage 97.6% 97.6%
======================================
Files 290 291 +1
Lines 65913 66055 +142
======================================
+ Hits 64369 64514 +145
+ Misses 1544 1541 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Exercise multi-file truncation and the exact output limit so arithmetic and comparison mutations cannot survive. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Exercise renderer early termination, diagnostic write failures, and empty diagnostic filtering to restore complete patch coverage. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sander Saares (sandersaares)
left a comment
There was a problem hiding this comment.
[Copilot speaking]
Published 9 findings. No finding follows up on an existing discussion thread.
See diagnostics
| Diagnostic | Value |
|---|---|
| Cache | Hit |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🟡 Changes recommended
The new implementation guide contains an inaccurate invariant description (it attributes line ordering to the parser’s map rather than the now-explicit sorting) that should be corrected to match the current behavior.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 23/24 changed files
- Comments generated: 1
- Review effort level: Lite
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🟢 Approval recommended
The changes consistently preserve failure diagnostics at the correct step boundary and the new coverage-gate diagnostics are deterministic, bounded, and covered by updated tests/snapshots.
Review details
- Files reviewed: 23/24 changed files
- Comments generated: 0 new
- Review effort level: Lite
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🟢 Approval recommended
The changes consistently preserve CI diagnostics while adding deterministic, bounded coverage failure details with corresponding tests/docs and no evident correctness or integration issues in the reviewed diffs.
Review details
- Files reviewed: 23/24 changed files
- Comments generated: 0 new
- Review effort level: Lite
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🟢 Approval recommended
The changes are cohesive, deterministically implemented, and backed by updated unit/CLI/snapshot coverage that exercises the new diagnostic and CI-failure-propagation behavior.
Review details
- Files reviewed: 23/24 changed files
- Comments generated: 0 new
- Review effort level: Lite
🤖 Fixes CI failures whose useful recipe output could be obscured by a later synthetic failure step. This was exposed by the Windows coverage gate in run 33158834495, where cargo-gamma-rt measured 90.7% against a 90.8% threshold but the failed step did not present that diagnosis clearly.
Changes
Validation