-
Notifications
You must be signed in to change notification settings - Fork 2
perf(cargo-anvil): parallelize Miri test artifacts #123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
st-dev-gh
wants to merge
6
commits into
main
Choose a base branch
from
u/st-dev-gh/miri
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
e9579a6
perf(cargo-anvil): parallelize Miri test artifacts
431138f
perf(cargo-anvil): remove Miri memory telemetry
4797f90
test(cargo-anvil): isolate Miri recipe fixtures
d855c41
fix(cargo-anvil): select Miri Cargo toolchains explicitly
e8c91b5
fix(cargo-anvil): address Miri review feedback
d459407
test(cargo-anvil): make Miri contracts portable
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Copilot speaking]
Explain why stricter Miri profiles retain the full Miri OS matrix
The design states that the stricter scheduled Miri profiles use the same operating-system matrix as
pr-runtime-analysis, but the explanation only restates the policy: operating systems considered worth standard Miri also receive the harder profiles. It does not document why the expensive profiles must not use a smaller matrix.Reproducible reasoning: Tree Borrows, strict provenance, and race coverage cost hours per leg, so reducing their operating-system coverage is an attractive future optimization. The current text does not give a maintainer enough information to evaluate that change. The decision depends on the catalog's single-tier-per-group constraint and on preserving detection of profile-specific undefined behavior on every operating system where Miri is supported; those considerations are not evident from the matrix counts themselves.
Consequence: A maintainer trying to reduce scheduled cost could narrow the stricter profiles to fewer operating systems and unintentionally remove coverage for undefined behavior that appears only under one of those profiles on an omitted platform.
Recommended action: Document the constraint and intended coverage outcome next to the matrix statement: using a smaller matrix would leave profile-specific behavior unchecked on supported Miri platforms, and the tier/group structure does not provide a separate subset without changing the catalog organization.
Impacted locations:
crates/cargo-anvil/docs/design/checks.md:255