Fix TraceParserGen to generate meaningful parser for WPF #1406
Conversation
|
|
oatkins
force-pushed
the
fix-trace-parser-gen
branch
from
72116c4 to
df8f9c9
Compare
oatkins
force-pushed
the
fix-trace-parser-gen
branch
from
df8f9c9 to
a727a4d
Compare
|
See also #950 - need to make sure the problems resolved there are not reintroduced here. |
| @@ -276,8 +304,10 @@ private void GenerateTemplateDefs(TextWriter output) | |||
| state = ", state"; | |||
| } | |||
|
|
|||
| output.WriteLine(" return new {0}(action, {1}, {2}, \"{3}\", Guid.Empty, {4}, \"{5}\", ProviderGuid, ProviderName {6});", | |||
| templateClassName, evnt.Id, evnt.Task, TraceParserGen.ToCSharpName(evnt.TaskName), evnt.Opcode, TraceParserGen.ToCSharpName(evnt.OpcodeName), state); | |||
| var taskGuid = string.IsNullOrEmpty(evnt.TaskName) ? "Guid.Empty" : ToCSharpName(evnt.TaskName) + "TaskGuid"; | |||
There was a problem hiding this comment.
Shouldn't it check m_taskGuids?
If there is no "eventGUID" attributes in parsed manifest, I think it should return Guid.Empty.
|
We're working to clean-up old open PRs in this repo. This PR is greater than 1 year old. If you would like to continue working on this PR, please add a comment within the next 7 days so that we can start discussion on next steps. Otherwise, we will close this PR. Please feel free to open a new PR or issue if you'd like to re-open this discussion at a later date. |
|
Closing this PR as it is greater than 1 year old. If you'd like to continue working on this, please open a new PR or issue to discuss next steps. |
This attempts to resolve #1351 and supports creating a parser for the Microsoft-Windows-WPF provider from the manifest at C:\Windows\Microsoft.NET\Framework\v4.0.30319\WPF\wpf-etw.man.
See also #554.
Addresses various issues with the generated provider:
RegisterTemplate()seems not to exist;source.RegisterEventTemplateis apparently what was intended.