chore: rename *ConnectionTimeout to *SocketTimeout #35583
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to avoid confusion in our codebase.
Test results for "tests 1"4 flaky39116 passed, 806 skipped Merge workflow run. |
mxschmitt
reviewed
Apr 11, 2025
| // PLAYWRIGHT_DOWNLOAD_CONNECTION_TIMEOUT is a misnomer, it actually controls the socket's | ||
| // max idle timeout. Unfortunately, we cannot rename it without breaking existing user workflows. | ||
| const downloadSocketTimeoutEnv = getFromENV('PLAYWRIGHT_DOWNLOAD_CONNECTION_TIMEOUT'); | ||
| const downloadSocketTimeout = +(downloadSocketTimeoutEnv || '0') || 30_000; |
There was a problem hiding this comment.
Suggested change
| const downloadSocketTimeout = +(downloadSocketTimeoutEnv || '0') || 30_000; | |
| const downloadSocketTimeout = +(downloadSocketTimeoutEnv || '0') ?? 30_000; |
lets fix this bug as a drive-by as well. Before passing 0 as an env var never worked.
There was a problem hiding this comment.
The fix you suggest will always set downloadSocketTimeout to 0 if the env variable is not provided (i.e. it would be equivalent to const downloadSocketTimeout = +(downloadSocketTimeoutEnv || '0')). I can address this issue separately from safe renaming (or not touch at all).
mxschmitt
approved these changes
Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to avoid confusion in our codebase.