Skip to content

Conversation

@souvlakias
Copy link

@souvlakias souvlakias commented Oct 25, 2025

mouse.click is a shortcut of [move, down, up], so it should accept move's options.
The same applies to dblclick, and to the click/dblclick methods of Locator and ElementHandle classes.
Also adds a missing await in mouse.click

References: #38006

Notes

Not sure what the values of * since: should be in the docs .md files 😅
This is my first interaction with this codebase so please let me know if I missed anything that also needs updating.

`click` is a shortcut of `move` and `down`, `up` so it should accept `move`s options.
same for `dblclick`
Also adds a missing `await`

References: microsoft#38006
@souvlakias
Copy link
Author

@souvlakias please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

This includes `Locator`s and `ElementHandle`s `click` and `dblclick` methods
@souvlakias souvlakias marked this pull request as draft October 28, 2025 12:37
@souvlakias souvlakias changed the title feat(mouse): add steps option to mouse.click feat(mouse): add steps option to callers of mouse.move Oct 28, 2025
@souvlakias souvlakias changed the title feat(mouse): add steps option to callers of mouse.move feat(mouse): add steps option to click methods Oct 28, 2025
@souvlakias souvlakias marked this pull request as ready for review October 28, 2025 12:51
@agg23
Copy link
Contributor

agg23 commented Oct 28, 2025

Superseding this with #38036. I'm sorry to steal your PR, but I felt that the back and forth necessary to land this (tiny nit-picky things and some design changes the team wanted) was something to be avoided.

If it helps, you did a pretty good job for your first contribution to the codebase. Thank you

@agg23 agg23 closed this Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants