fix(trace-viewer): Don't show 'Merge files' setting in trace viewer #38021
+46
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…setting-trace-viewer # Conflicts: # packages/trace-viewer/src/ui/workbenchLoader.tsx
agg23
reviewed
Oct 28, 2025
There was a problem hiding this comment.
I would handle this a different way. Rather than requiring consumers to selectively choose which settings should be rendered, the original DefaultSettingsView should have a prop (or detect) that it is in UI Mode/Trace Viewer and display a subset of options based on that. Requiring consumers to make the right choices as per settings to display is likely to cause errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This setting should only be visible in UI mode
After; trace viewer, UI:
Closes: #37969