Skip to content

chore: run global setup in test tools #38040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore: run global setup in test tools #38040

wants to merge 2 commits into from

Conversation

@pavelfeldman
Copy link
Member

No description provided.

yury-s
yury-s approved these changes Oct 29, 2025
View reviewed changes
packages/playwright/src/mcp/test/testContext.ts
if (result.status === 'passed' && !reporter.suite?.allTests().length)
throw new Error('seed test not found.');
try {
const reporter = new ListReporter({ configDir, screen, includeTestId: true });
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is it different from the global setup reporter?

@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions
Copy link
Contributor

Test results for "MCP"

40 failed
❌ [chrome] › mcp/test-setup.spec.ts:59 › setup should run global setup and teardown @mcp-macos-15
❌ [chrome] › mcp/test-setup.spec.ts:80 › test_run should run global setup and teardown @mcp-macos-15
❌ [chrome] › mcp/test-setup.spec.ts:104 › test_debug should run global setup and teardown @mcp-macos-15
❌ [chromium] › mcp/test-setup.spec.ts:59 › setup should run global setup and teardown @mcp-macos-15
❌ [chromium] › mcp/test-setup.spec.ts:80 › test_run should run global setup and teardown @mcp-macos-15
❌ [chromium] › mcp/test-setup.spec.ts:104 › test_debug should run global setup and teardown @mcp-macos-15
❌ [firefox] › mcp/test-setup.spec.ts:59 › setup should run global setup and teardown @mcp-macos-15
❌ [firefox] › mcp/test-setup.spec.ts:80 › test_run should run global setup and teardown @mcp-macos-15
❌ [firefox] › mcp/test-setup.spec.ts:104 › test_debug should run global setup and teardown @mcp-macos-15
❌ [webkit] › mcp/test-setup.spec.ts:59 › setup should run global setup and teardown @mcp-macos-15
❌ [webkit] › mcp/test-setup.spec.ts:80 › test_run should run global setup and teardown @mcp-macos-15
❌ [webkit] › mcp/test-setup.spec.ts:104 › test_debug should run global setup and teardown @mcp-macos-15
❌ [chrome] › mcp/test-setup.spec.ts:59 › setup should run global setup and teardown @mcp-ubuntu-latest
❌ [chrome] › mcp/test-setup.spec.ts:80 › test_run should run global setup and teardown @mcp-ubuntu-latest
❌ [chrome] › mcp/test-setup.spec.ts:104 › test_debug should run global setup and teardown @mcp-ubuntu-latest
❌ [chromium] › mcp/test-setup.spec.ts:59 › setup should run global setup and teardown @mcp-ubuntu-latest
❌ [chromium] › mcp/test-setup.spec.ts:80 › test_run should run global setup and teardown @mcp-ubuntu-latest
❌ [chromium] › mcp/test-setup.spec.ts:104 › test_debug should run global setup and teardown @mcp-ubuntu-latest
❌ [firefox] › mcp/test-setup.spec.ts:59 › setup should run global setup and teardown @mcp-ubuntu-latest
❌ [firefox] › mcp/test-setup.spec.ts:80 › test_run should run global setup and teardown @mcp-ubuntu-latest
❌ [firefox] › mcp/test-setup.spec.ts:104 › test_debug should run global setup and teardown @mcp-ubuntu-latest
❌ [webkit] › mcp/test-setup.spec.ts:59 › setup should run global setup and teardown @mcp-ubuntu-latest
❌ [webkit] › mcp/test-setup.spec.ts:80 › test_run should run global setup and teardown @mcp-ubuntu-latest
❌ [webkit] › mcp/test-setup.spec.ts:104 › test_debug should run global setup and teardown @mcp-ubuntu-latest
❌ [chrome] › mcp/test-setup.spec.ts:59 › setup should run global setup and teardown @mcp-windows-latest
❌ [chrome] › mcp/test-setup.spec.ts:80 › test_run should run global setup and teardown @mcp-windows-latest
❌ [chrome] › mcp/test-setup.spec.ts:104 › test_debug should run global setup and teardown @mcp-windows-latest
❌ [chromium] › mcp/test-setup.spec.ts:59 › setup should run global setup and teardown @mcp-windows-latest
❌ [chromium] › mcp/test-setup.spec.ts:80 › test_run should run global setup and teardown @mcp-windows-latest
❌ [chromium] › mcp/test-setup.spec.ts:104 › test_debug should run global setup and teardown @mcp-windows-latest
❌ [firefox] › mcp/launch.spec.ts:113 › isolated context @mcp-windows-latest
❌ [firefox] › mcp/test-setup.spec.ts:59 › setup should run global setup and teardown @mcp-windows-latest
❌ [firefox] › mcp/test-setup.spec.ts:80 › test_run should run global setup and teardown @mcp-windows-latest
❌ [firefox] › mcp/test-setup.spec.ts:104 › test_debug should run global setup and teardown @mcp-windows-latest
❌ [webkit] › mcp/test-setup.spec.ts:59 › setup should run global setup and teardown @mcp-windows-latest
❌ [webkit] › mcp/test-setup.spec.ts:80 › test_run should run global setup and teardown @mcp-windows-latest
❌ [webkit] › mcp/test-setup.spec.ts:104 › test_debug should run global setup and teardown @mcp-windows-latest
❌ [msedge] › mcp/test-setup.spec.ts:59 › setup should run global setup and teardown @mcp-windows-latest
❌ [msedge] › mcp/test-setup.spec.ts:80 › test_run should run global setup and teardown @mcp-windows-latest
❌ [msedge] › mcp/test-setup.spec.ts:104 › test_debug should run global setup and teardown @mcp-windows-latest

2543 passed, 108 skipped

Merge workflow run.

@github-actions
Copy link
Contributor

Test results for "tests 1"

3 failed
❌ [playwright-test] › reporter-html.spec.ts:724 › merged › should warn user when viewing via file:// protocol @macos-latest-node18-2
❌ [playwright-test] › reporter-html.spec.ts:3005 › created › execSync doesnt produce a second stdout attachment @macos-latest-node18-2
❌ [playwright-test] › reporter-junit.spec.ts:129 › merged › should handle large number of console logs @windows-latest-node18-1

2 flaky ⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:1079 › cli codegen › should not throw csp directive violation errors `@firefox-ubuntu-22.04-node18`
⚠️ [firefox-page] › page/page-emulate-media.spec.ts:144 › should keep reduced motion and color emulation after reload `@firefox-ubuntu-22.04-node18`

45744 passed, 808 skipped

Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yury-s yury-s yury-s approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pavelfeldman @yury-s