Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pyinstaller hiddent import #2193

Merged
merged 5 commits into from
Mar 5, 2024
Merged

Conversation

YingChen1996
Copy link
Contributor

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

Ying Chen added 2 commits March 1, 2024 19:02
Copy link

github-actions bot commented Mar 1, 2024

SDK CLI Global Config Test Result chenyin/update_pyinstaller_spec

2 tests   2 ✅  46s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit e88e234.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Mar 1, 2024

promptflow SDK CLI Azure E2E Test Result chenyin/update_pyinstaller_spec

  4 files    4 suites   3m 44s ⏱️
167 tests 147 ✅ 20 💤 0 ❌
668 runs  588 ✅ 80 💤 0 ❌

Results for commit e88e234.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Mar 1, 2024

SDK CLI Test Result chenyin/update_pyinstaller_spec

   12 files     12 suites   41m 45s ⏱️
  439 tests   423 ✅ 16 💤 0 ❌
1 756 runs  1 692 ✅ 64 💤 0 ❌

Results for commit e88e234.

♻️ This comment has been updated with latest results.

@YingChen1996 YingChen1996 marked this pull request as ready for review March 1, 2024 12:40
@YingChen1996 YingChen1996 requested a review from a team as a code owner March 1, 2024 12:40
wangchao1230
wangchao1230 previously approved these changes Mar 2, 2024
@elliotzh elliotzh merged commit 17b51a2 into main Mar 5, 2024
34 checks passed
@elliotzh elliotzh deleted the chenyin/update_pyinstaller_spec branch March 5, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants