Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check for both str and Path when executing a prompt #158

Merged
merged 2 commits into from
Jan 9, 2025
Merged

check for both str and Path when executing a prompt #158

merged 2 commits into from
Jan 9, 2025

Conversation

snosrap
Copy link
Contributor

@snosrap snosrap commented Jan 1, 2025

Could also use os.PathLike, which feels more correct but would require another import

@snosrap
check for both str and Path when executing a prompt
3a57f7e 
Could also use os.PathLike, which feels more correct but would require another import
@snosrap
Copy link
Contributor Author

snosrap commented Jan 1, 2025

Addresses #157

@snosrap
Copy link
Contributor Author

snosrap commented Jan 2, 2025

@microsoft-github-policy-service agree

sethjuarez
sethjuarez approved these changes Jan 9, 2025
View reviewed changes
Copy link
Member

@sethjuarez sethjuarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. Merging.

@sethjuarez sethjuarez merged commit 461b433 into microsoft:main Jan 9, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sethjuarez sethjuarez sethjuarez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@snosrap @sethjuarez