Fix global phase for controlled-T, R1 #2112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The decomposition for controlled-`T` in the stdlib uses `Rz` gates that are correct up to a global phase, which is fine for hardware but distracting in simulation. Correcting for that global phase in `T` fixes the global phase in `S`, which in turn allows removing a patch that made `R1` use a global phase consistent with `S`. Fixes #2106
|
Change in memory usage detected by benchmark. Memory Report for f896233
|
billti
reviewed
Jan 22, 2025
DmitryVasilevsky
approved these changes
Jan 22, 2025
|
Change in memory usage detected by benchmark. Memory Report for 62cb3a7
|
orpuente-MS
approved these changes
Jan 22, 2025
idavis
pushed a commit
that referenced
this pull request
Feb 2, 2025
The decomposition for controlled-`T` in the stdlib uses `Rz` gates that are correct up to a global phase, which is fine for hardware but distracting in simulation. Correcting for that global phase in `T` fixes the global phase in `S`, which in turn allows removing a patch that made `R1` use a global phase consistent with `S`. Fixes #2106
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The decomposition for controlled-
Tin the stdlib usesRzgates that are correct up to a global phase, which is fine for hardware but distracting in simulation. Correcting for that global phase inTfixes the global phase inS, which in turn allows removing a patch that madeR1use a global phase consistent withS.Fixes #2106