Fix widgets sometimes rendering in light theme when VS Code is in a dark theme #2120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billti
requested review from
minestarks,
sezna,
idavis and
swernli
as code owners
ScottCarda-MS
approved these changes
Jan 22, 2025
minestarks
reviewed
Jan 22, 2025
minestarks
approved these changes
Jan 22, 2025
idavis
pushed a commit
that referenced
this pull request
Feb 2, 2025
…ark theme (#2120) (See related issues microsoft/vscode-jupyter#7161 and microsoft/vscode-jupyter#9403 for more background) Our CSS override to address the widget theming issue wasn't working somtimes, which was very frustrating, as in Dark Mode our widgets would often appear as they should in light mode. The reason is that the order in which the style sheets get injected is non-deterministic, and as the 'problematic' CSS rule and the override to fix it have the same specificity, it would be 'last one wins'. Sometimes our style-sheet is last and it works... <img width="955" alt="image" src="https://github.com/user-attachments/assets/281524d8-a3d5-4d15-a649-442a21b5ddec" /> And sometimes the IPyWidgets 'force it to white' rule is last so the issue persists... <img width="960" alt="image" src="https://github.com/user-attachments/assets/f60f762e-0312-49de-9a2d-6f3cf4833b20" /> The unfortunate best _hack_ I could come up with is to programmatically ensure the override CSS rule is always last in the `style`s in the header. Not pretty, but it works.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(See related issues microsoft/vscode-jupyter#7161 and microsoft/vscode-jupyter#9403 for more background)
Our CSS override to address the widget theming issue wasn't working somtimes, which was very frustrating, as in Dark Mode our widgets would often appear as they should in light mode.
The reason is that the order in which the style sheets get injected is non-deterministic, and as the 'problematic' CSS rule and the override to fix it have the same specificity, it would be 'last one wins'. Sometimes our style-sheet is last and it works...
And sometimes the IPyWidgets 'force it to white' rule is last so the issue persists...
The unfortunate best hack I could come up with is to programmatically ensure the override CSS rule is always last in the
styles in the header.Not pretty, but it works.