Fix Visual Studio deadlock caused by restore target calls in BeforeResolveReferences #15137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove MSBuild calls to Restore target from BeforeResolveReferences in VS builds - Add explanatory comments documenting why restore calls cause deadlocks - Preserve all other functionality while fixing the deadlock issue - Visual Studio will handle NuGet restoration through its own mechanisms Co-authored-by: anupriya13 <[email protected]>
Copilot
AI
changed the title
[WIP] Calling the
Fix Visual Studio deadlock caused by restore target calls in BeforeResolveReferences
Sep 11, 2025
restore target in VS leads to a deadlock
Copilot finished work on behalf of
anupriya13
September 11, 2025 04:36
nkolev92
approved these changes
Sep 16, 2025
|
The "problematic" target served a purpose: allowing developers to fully build (and fetch C++ dependencies) from within Visual Studio. If there is no way around dropping this target, documentation should also be updated including a workaround to restore dependencies outside the IDE. |
| 2. It violates the restore/build contract (restore must complete before build starts) | ||
| 3. Network calls during restore on UI thread cause performance issues and potential deadlocks | ||
| Visual Studio will handle NuGet package restoration automatically through its own mechanisms. |
There was a problem hiding this comment.
Can you please confirm this actually happens and the target's removal is fully transparent to the user?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a critical deadlock issue in Visual Studio when building React Native Windows C++ projects. The problem occurred when MSBuild targets called the
Restoretarget during theBeforeResolveReferencesphase of Visual Studio builds.Problem
The
BeforeResolveReferencestarget in bothMicrosoft.ReactNative.Common.targetsandvnext/Directory.Build.targetswas calling the NuGetRestoretarget whenBuildingInsideVisualStudiowas true. This caused several issues:Solution
Removed the problematic
BeforeResolveReferencestargets that were callingMSBuildtasks withTargets="Restore". Visual Studio has its own built-in NuGet package restoration mechanisms that handle this properly without the deadlock risk.The fix includes:
BeforeResolveReferencestargets from both affected filesFiles Changed
vnext/PropertySheets/External/Microsoft.ReactNative.Common.targetsvnext/Directory.Build.targetsBoth files had identical problematic patterns that have been resolved.
Fixes #15108.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.
Microsoft Reviewers: Open in CodeFlow