Skip to content

tests/opa: normalize path separators in folder filter on Windows #742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anakrish merged 1 commit into from
Jun 5, 2026
Merged

tests/opa: normalize path separators in folder filter on Windows #742

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion tests/opa.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -380,7 +380,11 @@ fn run_opa_tests(opa_tests_dir: String, folders: &[String]) -> Result<()> {
}
let path = Path::new(&path_str);
let path_dir = path.strip_prefix(tests_path)?.parent().unwrap();
let path_dir_str = path_dir.to_string_lossy().to_string();
// Normalize to forward slashes so the folder filter at the
// `folders.iter().any(|f| &path_dir_str == f)` check below matches
// CLI arguments like `v0/aggregates` on Windows, where
// `to_string_lossy` yields backslash separators by default.
let path_dir_str = path_dir.to_string_lossy().replace('\\', "/");
Comment thread
anakrish marked this conversation as resolved.
let folder_name = folder_name_from_path(path_dir);
let skip_rvm_for_folder = folder_name
.as_deref()
Expand Down
Loading