-
Notifications
You must be signed in to change notification settings - Fork 248
fix(bug): Update logging for uninitialized VFP stats from warn to debug #958
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timraymond
reviewed
Nov 7, 2024
matmerr
requested changes
Nov 18, 2024
matmerr
previously approved these changes
Nov 21, 2024
171324f
to
e0bb58a
Compare
kamilprz
previously approved these changes
Nov 22, 2024
This PR will be closed in 7 days due to inactivity. |
kamilprz
previously approved these changes
Dec 31, 2024
matmerr
requested changes
Jan 22, 2025
ibezrukavyi
approved these changes
Feb 14, 2025
matmerr
approved these changes
Feb 14, 2025
Can we rename this PR? Just so the commit changelog reflects what is being changed, in this case change warn log to debug |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add node level metric for no VFPCounters. Tested the new metric works by calling the metrics endpoint inside the node of the windows retina pod:
Related Issue
#933
Checklist
git commit -S -s ...
). See this documentation on signing commits.Screenshots (if applicable) or Testing Completed
Please add any relevant screenshots or GIFs to showcase the changes made.
Additional Notes
The metric was generated as it brought outside the conditional statement for testing purposes only, i.e. metric can be compiled and incremented.
Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.