.Net: Add a request index to the streamed function call update content #10129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ers can group the messages by the request.
markwallace-microsoft
added
.NET
SergeyMenshykh
temporarily deployed
to
integration
GitHub Actions
Inactive
SergeyMenshykh
temporarily deployed
to
integration
GitHub Actions
Inactive
…from different requests
SergeyMenshykh
had a problem deploying
to
integration
GitHub Actions
Error
SergeyMenshykh
temporarily deployed
to
integration
GitHub Actions
Inactive
SergeyMenshykh
changed the title
SergeyMenshykh
temporarily deployed
to
integration
GitHub Actions
Inactive
SergeyMenshykh
temporarily deployed
to
integration
GitHub Actions
Inactive
westey-m
reviewed
Jan 14, 2025
dotnet/src/SemanticKernel.Abstractions/Contents/FunctionCallContentBuilder.cs
Outdated
Show resolved
Hide resolved
westey-m
approved these changes
Jan 14, 2025
markwallace-microsoft
approved these changes
Jan 14, 2025
dotnet/src/SemanticKernel.Abstractions/Contents/StreamingFunctionCallUpdateContent.cs
Show resolved
Hide resolved
SergeyMenshykh
temporarily deployed
to
integration
GitHub Actions
Inactive
SergeyMenshykh
temporarily deployed
to
integration
GitHub Actions
Inactive
westey-m
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context:
Today, it's impossible to determine which request a streaming function call update belongs to or originates from. As a result, if an AI service interaction leads to multiple requests to an AI model - let's say one per function call - it's impossible to assemble the function call contents from the streamed updates. This is because the streaming function call updates from the second request override those from the first one.
Description
This PR adds the
RequestIndexto theStreamingFunctionCallUpdateContentclass and updates the {Azure}OpenAI connectors to set it. Finally, it updates theFunctionCallContentBuilderclass to construct a composite index fromRequestIndexandFunctionCallIndexand uses it to uniquely identify the function call content updates across requests.Closes: #10006