Python: Add vector search to Postgres connector #10213
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markwallace-microsoft
added
python
Python Test Coverage Report •
Python Unit Test Overview
|
python/samples/getting_started/third_party/postgres-memory.ipynb
Outdated
Show resolved
Hide resolved
python/semantic_kernel/connectors/memory/postgres/postgres_collection.py
Outdated
Show resolved
Hide resolved
python/semantic_kernel/connectors/memory/postgres/postgres_collection.py
Outdated
Show resolved
Hide resolved
python/semantic_kernel/connectors/memory/postgres/postgres_collection.py
Outdated
Show resolved
Hide resolved
python/semantic_kernel/connectors/memory/postgres/postgres_collection.py
Outdated
Show resolved
Hide resolved
python/semantic_kernel/connectors/memory/postgres/postgres_collection.py
Outdated
Show resolved
Hide resolved
|
@eavanvalkenburg thanks for the review! I believe I addressed all your comments. |
python/semantic_kernel/connectors/memory/postgres/postgres_collection.py
Outdated
Show resolved
Hide resolved
python/semantic_kernel/connectors/memory/postgres/postgres_collection.py
Outdated
Show resolved
Hide resolved
python/semantic_kernel/connectors/memory/postgres/postgres_store.py
Outdated
Show resolved
Hide resolved
|
@eavanvalkenburg thanks - ready for re-review! |
python/semantic_kernel/connectors/memory/postgres/postgres_collection.py
Outdated
Show resolved
Hide resolved
TaoChenOSU
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Following up on #8951, this PR adds an implementation of
VectorSearchBasetoPostgresCollection. This implementation provides vectorized search and does not implement text search or vectorizable text search.Unit and integration tests are added, and the
python/samples/getting_started/third_party/postgres-memory.ipynbnotebook was expanded to include vector search in the example.Contribution Checklist